PHP Common Mistakes

A few simple and common code snippets are combined in this vulnerability ID.

1) $token = md5(microtime())

Tokens without enough entropy. Has its own code.

2) $cmd .= escapeshellcmd(...)

escapeshellcmd is only for the command, escapeshellarg is for the arguments. Otherwise you will allow spaces in the arguments, which creates multiple arguments.

3) mysql_connect(x, x, 'SecretPassword')

The 'mysql_connect' or 'mysqli_connect' call will set up a new connection to the database. In many examples found on the intranet the password is set literally set in the code. Production code should not have passwords in the source code, but instead use a password vaults or something equivalent, in order to de-risk the source code.